Introduce Omron Device Pairing #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 78.27% 79.06% +0.79%
==========================================
Files 56 39 -17
Lines 2144 1671 -473
==========================================
- Hits 1678 1321 -357
+ Misses 466 350 -116
Continue to review full report in Codecov by Sentry.
|
Supereg
force-pushed
the
feature/control-point
branch
2 times, most recently
from
63411fc to
d57297c
Compare
Supereg
force-pushed
the
feature/control-point
branch
from
d57297c to
20e37da
Compare
…ame editing functionality.
PSchmiedmayer
approved these changes
Jun 29, 2024
There was a problem hiding this comment.
Thank you for the work on the ENGAGE-HF app @Supereg! Great additions with Spezi Devices and all the work here! Very smooth integration.
I mainly had two API design comments that are nice to spot here in the integration, everything else looks great, only smaller comments.
ENGAGEHF.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Outdated
Show resolved
Hide resolved
Supereg
added a commit
that referenced
this pull request
Jul 2, 2024
# Fix beta deployment ## ♻️ Current situation & Problem There was one change accidentally checked in with #16. This PR reverts that to fix beta deployments. ## ⚙️ Release Notes * Fix beta deployments. ## ✅ Testing Verified in Xcode UI. ### Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md).
|
Amazing job with this PR @Supereg; great to see all the results in the ENGAGE-HF app! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce Omron Device Pairing
♻️ Current situation & Problem
This PR changes how we handle device interaction with Omron devices. Instead of continuously browsing for weigh scale and blood pressure devices in the environment, the user pairs with a specific Omron devices via the new Devices Tab. The devices tab shows all currently paired devices, their connection status (currently connected vs. last seen) and additional information like battery. Further, it provides customizability to name your devices.
⚙️ Release Notes
📚 Documentation
--
✅ Testing
Functionality is tested as part of the SpeziDevices package. Functionality was manually verified using real Omron devices.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: